Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Fix random seed calculation - Closes #6381 #6382

Merged
merged 2 commits into from
May 5, 2021

Conversation

shuse2
Copy link
Collaborator

@shuse2 shuse2 commented May 5, 2021

What was the problem?

This PR resolves #6381

How was it solved?

  • Remove the special handling of round === 1 because if the init round > 1, this will never be called. Also, it should be consistent with the case where all seed reveal was invalid
  • if the block does not exist in memory, it skips the check instead of throwing. This happens on check before genesis block height

How was it tested?

Sync with migrated testnet node

@shuse2 shuse2 self-assigned this May 5, 2021
@shuse2 shuse2 changed the base branch from development to hotfix/5.0.5 May 5, 2021 10:39
Copy link
Contributor

@IkerAlus IkerAlus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shuse2 shuse2 merged commit cef9e1f into hotfix/5.0.5 May 5, 2021
@shuse2 shuse2 deleted the 6381-fix-random-seed-calculation branch May 5, 2021 14:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fail to calculate random seed on migrated nodes
4 participants